Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FOUNDATION_EXPORT over extern #1977

Merged

Conversation

skyline75489
Copy link
Member

New Pull Request Checklist

  • I have read and understood the CONTRIBUTING guide

  • I have read the Documentation

  • I have searched for a similar pull request in the project and found none

  • I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

  • I have added the required tests to prove the fix/feature I am adding

  • I have updated the documentation (if necessary)

  • I have run the tests and they pass

  • I have run the lint and it passes (pod lib lint)

Pull Request Description

Use FOUNDATION_EXPORT over extern to be compatible with C++.

@bpoplauschi bpoplauschi added this to the 4.1.1 milestone Aug 2, 2017
@bpoplauschi bpoplauschi merged commit cd84881 into SDWebImage:master Aug 2, 2017
@bpoplauschi
Copy link
Member

Looks good @skyline75489

@skyline75489 skyline75489 deleted the fix/use-foundation-export branch August 3, 2017 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants