Fix static analyser warnings

rs · Nov 22, 2010 · 3f016b4 · 3f016b4
1 parent bec7243
commit 3f016b4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/Classes/ShareKit/Core/Helpers/OAuth/Crytpo/Base64Transcoder.c b/Classes/ShareKit/Core/Helpers/OAuth/Crytpo/Base64Transcoder.c
@@ -160,6 +160,7 @@ else if (theRemainingBytes == 2)
 		outOutputData[theOutIndex++] = '\n';
 		}
 	}
+    theOutIndex; // make static analyzer happy
 return(true);
 }
 

diff --git a/Classes/ShareKit/Core/Helpers/OAuth/Crytpo/sha1.c b/Classes/ShareKit/Core/Helpers/OAuth/Crytpo/sha1.c
@@ -96,8 +96,6 @@ static unsigned char workspace[64];
     state[2] += c;
     state[3] += d;
     state[4] += e;
-    /* Wipe variables */
-    a = b = c = d = e = 0;
 }
 
 
@@ -141,7 +139,7 @@ unsigned int i, j;
 
 void SHA1Final(unsigned char digest[20], SHA1_CTX* context)
 {
-unsigned long i, j;
+unsigned long i;
 unsigned char finalcount[8];
 
     for (i = 0; i < 8; i++) {
@@ -157,8 +155,6 @@ unsigned char finalcount[8];
         digest[i] = (unsigned char)
          ((context->state[i>>2] >> ((3-(i & 3)) * 8) ) & 255);
     }
-    /* Wipe variables */
-    i = j = 0;
     memset(context->buffer, 0, 64);
     memset(context->state, 0, 20);
     memset(context->count, 0, 8);