Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go has a dedicated type to express a duration:
time.Duration
. Using it simplifies the interface as it doesn't require reading up on what unit to use for theMaxAge
parameter.This change breaks backwards compatibility but it's trivial to fix (i.e. just add
* time.Second
to the previous configuration value). Ultimately up to you to decide if it's worth the minor inconvenience it will cause for users updating the library.