Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
phuslu/log is another logger that claims to be faster [reference] than both uber-go/zap and rs/zerolog.
This pull request includes phuslu/log into the benchmark results. However, currently the logger is not compatible with the test validation because the timestamp field is always enabled, and the duration encoder is
string
(e.g.1ms
) rather thanint
(e.g.1
).Test failure due to timestamp can't be disabled in phuslu/logFixed bydelete(got, "ts")
in L437 ofmain_test.go
Test failure due to different time and duration encoding being used in phuslu/log
phuslu/log outputs the current time if the given
TimeFormat
is empty, which is causing some of the validations to fail as well.This pull request is ready when phuslu/log#29 is resolved.