[jsonschema] Bug: error not returned from Encoder

[smyrman]

While donig some test-cleanup in the jsonschema package, I found a bug where errors in encoding a validator are never returned from jsonschema.Encoder.

I found this bug while changing this test:

-func TestErrNotImplemented(t *testing.T) {
-       validator := &schema.IP{}
-       b := new(bytes.Buffer)
-       assert.Equal(t, ErrNotImplemented, validatorToJSONSchema(b, validator))
-}

Into one that tests the public interface:

+type dummyValidator struct{}
+
+func (v dummyValidator) Validate(value interface{}) (interface{}, error) {
+       return value, nil
+}
+
+func TestErrNotImplemented(t *testing.T) {
+       s := schema.Schema{
+               Fields: schema.Fields{
+                       "i": {
+                               Validator: &dummyValidator{},
+                       },
+               },
+       }
+       enc := jsonschema.NewEncoder(new(bytes.Buffer))
+       assert.Equal(t, jsonschema.ErrNotImplemented, enc.Encode(&s))
+}

PS! The result is the same if &schema.IP{} is used as Validator in the new test.

I am trying to see if I can fix this together with my change.

[smyrman]

@yanfali, pinging you about this so you are aware. Should be fixed by #64.

[smyrman]

Since #64 is merged, this issue can be closed.