Thinko. Actually put the files in the hierarchy #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- a big mistake on my part was not testing the code outside of the path. This commit fixes the hierarchy and adds a test to ensure that the import path functions. - add a documentation file to encoding to satisfy compiler
yanfali
force-pushed
the
yanfali-fix-package-hierarchy
branch
from
b7e6cfc
to
b814b98
Compare
| @@ -0,0 +1,24 @@ | |||
| package encoding | |||
There was a problem hiding this comment.
Shouldn't tests be in the same package as jsonschema?
|
In this case no, because it's specifically to test that importing paths work correctly. The mistake I made earlier was to not try and import from another package, but only use it from the same package :( |
|
Got it. That's why I always happened |
|
Thanks! |
|
Forget what I said, I must have dreamed it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
path. This commit fixes the hierarchy and adds a test to ensure that
the import path functions.