Fix: Event.stack initialization error #219
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
version: github.com/rs/zerolog/log v1.18.0
When I test the following code
according to my understanding, err with
id = 2
will output stack information, whileid = 1
andid = 3
will only output normal error informationbut the output is not consistent with what I understand
I found that the Event taken from the Pool did not initialize the stack, causing the stack to be reused
When I make the following changes, the result is correct
https://github.com/haozibi/zerolog/blob/6820ccdb22c5e934beb81a2c27e7778201d363cd/event.go#L56-L67