Add support for hex-encoded bytes #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also fixed up some tests that were missing the |
rs
reviewed
Mar 15, 2018
event.go
Outdated
| if e == nil { | ||
| return e | ||
| } | ||
| e.buf = json.AppendString(json.AppendKey(e.buf, key), hex.EncodeToString(val)) |
There was a problem hiding this comment.
You could create a json.AppendHex that just does:
func AppendHex(buf, val []byte) []byte {
const hextable = "0123456789abcdef"
for _, v := range val {
buf = append(buf, hextable[v>>4], hextable[v&0x0f])
}
return buf
}This would avoid the slice heap allocation done by hex.EncodeToString.
There was a problem hiding this comment.
Done. I also added comments for all the AppendXXX(...) functions that were missing them to shut up the linter.
rs
reviewed
Mar 15, 2018
internal/json/string.go
Outdated
| for _, v := range s { | ||
| dst = append(dst, hex[v>>4], hex[v&0x0f]) | ||
| } | ||
| dst = append(dst, s...) |
There was a problem hiding this comment.
Stupid copy-paste mistake. Fixing it up with the tests now.
|
It should be OK now. |
rs
approved these changes
Mar 15, 2018
|
Thx for your contrib 👍 |
|
Thank you for the nice logging library 👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for hex-encoded bytes by using the
Hex(...)functions instead of theBytes(...)functions. Most of the time, when logging a byte slice, this is what we want.I did not find a more efficient way to do this. It's a lot of overhead to manually encode each byte slice to a hex string whenever we want to log it in such a way, so I think the PR has merrit, even if it's a bit of a convenience feature.
The fact it's less efficient to use
Hex(...)thanBytes(...)should not matter, as it is optional to use and it would incure the same overhead when manually converting each time.