Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass program counter to CallerMarshalFunc #457

Merged
merged 2 commits into from Jul 29, 2022
Merged

pass program counter to CallerMarshalFunc #457

merged 2 commits into from Jul 29, 2022

Conversation

Hades32
Copy link
Contributor

@Hades32 Hades32 commented Jul 29, 2022

This passes the pc var to marshallers to be able to add function names to caller fields.

This is a breaking change for those that have overridden CallerMarshalFunc before, as the func signature changes.

All tests passed locally.

Resolves #456

log_test.go Outdated Show resolved Hide resolved
@Hades32 Hades32 requested a review from rs July 29, 2022 12:39
@rs rs merged commit d894f12 into rs:master Jul 29, 2022
@Hades32 Hades32 deleted the caller-pc branch July 29, 2022 15:05
@Hades32
Copy link
Contributor Author

Hades32 commented Jul 29, 2022

thanks for merging @rs! Would you mind also creating a new git tag, so I can update our deps?

@Hades32
Copy link
Contributor Author

Hades32 commented Aug 22, 2022

@rs could you create a v1.28.0 tag?

@rs
Copy link
Owner

rs commented Aug 28, 2022

done

rs pushed a commit that referenced this pull request Sep 9, 2022
There was changes in #457  pass program counter to CallerMarshalFunc.
Update example in README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass PC to caller marshaller to allow more detailed information
2 participants