bug fix: avoid descriptor exceptions on 0d arrays (e.g. strings) #121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check_descriptor_length casts each descriptor value to np.array. This can result in 0-d arrays if the input is str. The subsequent check on shape[0] then triggers an exception because 0-d arrays are weird and have no shape elements.
So I fixed that by flattening the array whenever the shape is empty. I also added a test.
Finally, I snuck in a stylistic change - single character variable names are rarely a good idea, and when the character clashes with a common pdb shortcut it's really ill advised.