Remove underscore as dependency #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Love this module! Thanks for making this!
This might be a little heavy-handed—apologies!—but this PR removes underscore as a dependency (kept as devDependency) since only two functions were used. This reduces the minified bundle size from 38kb to 14kb.
Changes:
_.everyis just a loop with a break. Slightly more verbose, but maybe offset by saving 24kb 😄_.uniqueis replaced withcompute-unique, which does precisely the same thing with only slightly different semantics.Again, I really don't mean to be the style police, but thought perhaps the bundle size savings were worthwhile. Thanks!