This repository has been archived by the owner on Jul 7, 2020. It is now read-only.
Use keyed fields in struct literals to appease go vet on Google AppEngine #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gine What === Use keyed fields in struct literals. Why === When pushing code to Google AppEngine that uses rsc.io/pdf, the code is rejected with the error: rsc.io/pdf/read.go:1055:9: composite struct literal crypto/cipher.StreamReader with unkeyed fields I don't see this error locally with go1.9, and assume this is a feature of go vet that has improved since go1.8.
leighmcculloch
added a commit
to leighmcculloch/clippercard
that referenced
this pull request
Dec 31, 2017
leighmcculloch
added a commit
to leighmcculloch/clippercard
that referenced
this pull request
Jan 1, 2018
leighmcculloch
added a commit
to leighmcculloch/clippercard
that referenced
this pull request
Jan 1, 2018
Repository owner
deleted a comment from
leighmcculloch
Jan 12, 2018
|
Thanks for accepting the fix! ❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use keyed fields in struct literals.
Why
When pushing code to Google AppEngine that uses rsc.io/pdf, the code is
rejected with the error:
rsc.io/pdf/read.go:1055:9: composite struct literal crypto/cipher.StreamReader with unkeyed fields
I don't see this error locally with go1.9, and assume this is a feature
of go vet that has improved since go1.8.