Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rf: fix example program to build #11

Merged
merged 1 commit into from
Mar 31, 2021
Merged

rf: fix example program to build #11

merged 1 commit into from
Mar 31, 2021

Conversation

prattmic
Copy link
Collaborator

This way we can use this program to try out the examples later in the
docs.

@prattmic
Copy link
Collaborator Author

Would it be valuable to put a copy of this in testdata with a trivial command (mv F Func) to make sure it keeps working. Unfortunately that would just be copy, so it could easily get out-of-date.

@mdempsky
Copy link
Collaborator

Would it be valuable to put a copy of this in testdata with a trivial command (mv F Func) to make sure it keeps working. Unfortunately that would just be copy, so it could easily get out-of-date.

I think if we had a way to make sure they stay in sync, that would be worthwhile. But otherwise, I'd worry they fall out of sync, and then it doesn't add any value.

I'm not that concerned about it, but patches welcome. :)

This way we can use this program to try out the examples later in the
docs.
@prattmic
Copy link
Collaborator Author

I've rebased for the build check update.

Sounds like we can just leave the testing as-is for now.

@mdempsky mdempsky merged commit fef562c into rsc:main Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants