Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runCommand: Fix unnecessary nil check #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abhinav
Copy link

@abhinav abhinav commented Feb 23, 2024

On the relevant line, wait is guaranteed to be non-nil
because there's a nil check a few lines ago that always returns.

wait, runErr := impl.Run(s, cmd.args...)
if wait == nil {
	if async && runErr == nil {
		return cmdError(cmd, errors.New("internal error: async command returned a nil WaitFunc"))
	}
	return checkStatus(cmd, runErr)
}

On the relevant line, wait is guaranteed to be non-nil
because there's a nil check a few lines ago that always returns.

	wait, runErr := impl.Run(s, cmd.args...)
	if wait == nil {
		if async && runErr == nil {
			return cmdError(cmd, errors.New("internal error: async command returned a nil WaitFunc"))
		}
		return checkStatus(cmd, runErr)
	}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant