Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named configs and version 2.7 support #6

Merged
merged 7 commits into from
Jun 13, 2024
Merged

Named configs and version 2.7 support #6

merged 7 commits into from
Jun 13, 2024

Conversation

rschmied
Copy link
Owner

  • making a somewhat bigger version bump due to some bigger changes
  • moved logging to log/slog
  • removed all the caching logic / code. It didn't really work well due to races. In addition, TF doesn't really keep a connection / client over multiple resource ca
    lls so the caching was somewhat limited even it would have properly worked (which it did not).
  • named configurations (added with CML 2.7)
  • added some tests for the named configs

- making a somewhat bigger version bump due to some bigger changes
- removed all the caching logic / code. It didn't really work well due
  to races.  In addition, TF doesn't really keep a connection / client
  over multiple resource calls so the caching was somewhat limited even
  it would have properly worked (which it did not).
- named configurations (added with CML 2.7)
- added some tests for the named configs
@coveralls
Copy link

Coverage Status

coverage: 88.306% (-3.4%) from 91.699%
when pulling a934564 on dev
into 5368653 on main.

@coveralls
Copy link

Coverage Status

coverage: 90.112% (-1.6%) from 91.699%
when pulling b34d3b3 on dev
into 5368653 on main.

@coveralls
Copy link

Coverage Status

coverage: 90.172% (-1.5%) from 91.699%
when pulling 8547e89 on dev
into 5368653 on main.

@rschmied
Copy link
Owner Author

yeah -- coverage decreased. but i guess i can live with this.

@rschmied rschmied merged commit 337ee89 into main Jun 13, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants