continue scanning one-liners when use if, autouse or >5.010 found #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the system returned feature.pm and ignored thre rest of the line.
Also update test descriptions for previous commit
|
Thanks, Shawn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scan_line was returning early and ignoring %found as soon as it encountered a line containing "use 5.010" (anything greater than v5.9.5), "use if" or "use autouse".
This meant it returned only feature.pm for one-liners such as "use 5.024; use Some::Other::Module". Similar issues occurred for the if and autouse pragmas.
There is still an early return when the package keyword is found. I'm not sure of the best way to handle that, though, as it sets a global $CurrentPackage so I assume it has knock-on effects. One also expects it to be uncommon in one-liners in the wild.