Issue #377 fix #378
Merged
Issue #377 fix #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public override ToString () : string | ||
| { | ||
| match (this){ | ||
| | Some (x) when x : object == null => "Some()" |
There was a problem hiding this comment.
I would presume that it does. Is that a problem?
There was a problem hiding this comment.
It is behaviour change, I am not sure if everyone accepts it.
It is possible to check whether T is not ValueType and only then check for null.
For instance
isValueType = typeof(T).IsValueType.
ToString() { if (isValueType) ToStringValue() else ToStringReference() }
It could be great if you could do this in compile time also :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just thought I'd fix the issue, on NN's suggestion.
I have also added an additional parameter for defining the entry point to the MSBuild task.