Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add events page proper #92

Merged
merged 3 commits into from
Mar 31, 2022
Merged

Add events page proper #92

merged 3 commits into from
Mar 31, 2022

Conversation

sdruskat
Copy link
Contributor

@sdruskat sdruskat commented Feb 23, 2022 •
edited
Loading

This PR fixes #91 and fixes #7 by

  • Moving the events page to the main body of the website
  • Adding a link to the navigation header
  • Adapting the page to slightly move scope away from just the Council
  • Remove section on council page that links to ex-Council events page

danielskatz
danielskatz approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@danielskatz danielskatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good

@sdruskat
Copy link
Contributor Author

Thanks for the review @danielskatz.
@benvanwerkhoven, feel free to merge this if you think this is good to go.

@sdruskat
Copy link
Contributor Author

I'll merge this now as there have been no further remarks.

@sdruskat sdruskat merged commit 59fafd5 into main Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielskatz danielskatz danielskatz approved these changes

@benvanwerkhoven benvanwerkhoven Awaiting requested review from benvanwerkhoven

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add events page Host a calendar for (strictly) RSE-relevant intl. events
2 participants
@sdruskat @danielskatz