testing shortening PR workflow #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsoch
force-pushed
the
shorten-workflows
branch
from
c29f4a9
to
864340a
Compare
vsoch
force-pushed
the
shorten-workflows
branch
2 times, most recently
from
b585184
to
7e4593a
Compare
|
Are these build failures expected? It kinda looks like missing directories? |
|
I think what is happening is that one is generated in the container and the other outside, so they are different - checking now with an echo! |
|
yep, behold, path inside and outside the container! Another artifact of trying to do something outside the container first instead of letting uptodate run the show! |
|
Huh the build matrices shouldn't all be running like that without changed files - let me look into that too. |
|
okay the issue was passing an empty string for parsed files (none found) which defaults to the PWD and will trigger all! I added another hack to fix it lol. |
vsoch
force-pushed
the
shorten-workflows
branch
from
fe3b0bc
to
2518d2e
Compare
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
vsoch
force-pushed
the
shorten-workflows
branch
from
d753ab4
to
e563365
Compare
davidbeckingsale
approved these changes
Feb 18, 2022
trws
reviewed
Feb 18, 2022
trws
reviewed
Feb 18, 2022
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
trws
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: vsoch vsoch@users.noreply.github.com