Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding locales generation to dockerfile #7

Merged
merged 4 commits into from
Sep 9, 2020
Merged

Adding locales generation to dockerfile #7

merged 4 commits into from
Sep 9, 2020

Conversation

vsoch
Copy link
Contributor

@vsoch vsoch commented Sep 9, 2020

Locales is needed for correct encoding.

Locales is needed for correct encoding.
Chilipp added a commit to SORSE/sorse.github.io that referenced this pull request Sep 9, 2020
Chilipp added a commit to SORSE/sorse.github.io that referenced this pull request Sep 9, 2020
@Chilipp
Copy link

Chilipp commented Sep 9, 2020

hmm, seems not to work. I ran it locally and it seems like it's still using the wrong encoding. So lets fix this with environment variables. Could you please add

ENV LC_ALL=en_US.UTF-8
ENV LANG=en_US.UTF-8
ENV LANGUAGE=en_US.UTF-8

to the docker file?

without, docker run -it --entrypoint python3 -v pwd:/github/workspace rseng/pdf-generator -c "import locale; print(locale.getpreferredencoding())" gives ANSI_X3.4-1968, with this settings, we get UTF-8 and it can read the problematic file.

@vsoch
Copy link
Contributor Author

vsoch commented Sep 9, 2020

@Chilipp
Copy link

Chilipp commented Sep 9, 2020

seems to work! thanks @vsoch

let me know when you made the new release

@vsoch
Copy link
Contributor Author

vsoch commented Sep 9, 2020

Sorry for the delay! I had to run and get a flu shot. First time stepping outside in 5 months, wowza.

@vsoch vsoch merged commit 7e928f1 into master Sep 9, 2020
@vsoch vsoch deleted the add/locales branch September 9, 2020 21:10
@vsoch
Copy link
Contributor Author

vsoch commented Sep 9, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants