Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update from annotate/taxonomy-dpshelio-2021-07-09/14-04-31 #231

Merged
merged 2 commits into from
Nov 14, 2021
Merged

Update from annotate/taxonomy-dpshelio-2021-07-09/14-04-31 #231

merged 2 commits into from
Nov 14, 2021

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 9, 2021

Fixes #230

@vsoch
Copy link
Contributor

vsoch commented Jul 9, 2021

@dpshelio could you explain your choices here - why you put that sunpy is an IDE?

dpshelio
dpshelio approved these changes Nov 14, 2021
View reviewed changes
Copy link
Contributor

@dpshelio dpshelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably selected IDE by mistake! Glad you catch it!!

database/github/sunpy/sunpy/taxonomy.tsv Outdated Show resolved Hide resolved
@vsoch @dpshelio
Update database/github/sunpy/sunpy/taxonomy.tsv
c58f3a9 
Co-authored-by: David Pérez-Suárez <dps.helio@gmail.com>
@vsoch vsoch merged commit a68acda into master Nov 14, 2021
@vsoch vsoch deleted the annotate/taxonomy-dpshelio-2021-07-09/14-04-31 branch November 14, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsoch vsoch vsoch approved these changes

@dpshelio dpshelio dpshelio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TAXONOMY]
2 participants
@vsoch @dpshelio