This repository has been archived by the owner on Jan 21, 2021. It is now read-only.
Add Python (pip), Void (xbps), and Fedora (dnf) support to package counts. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phate6660
changed the title
Phate6660
changed the title
lnicola
suggested changes
May 15, 2019
src/main.rs
Outdated
| fn get_package_count_fedora() -> Result<String> { | ||
| let dnf = Command::new("dnf").arg("list").arg("--installed").output().context(Pkgcount)?; | ||
| let pkgs = bytecount::count(&dnf.stdout, b'\n'); | ||
| let pkgs = pkgs as u32 - 1; |
src/main.rs
Outdated
| fn get_package_count_pip() -> Result<String> { | ||
| let pip = Command::new("pip").arg("list").output().context(Pkgcount)?; | ||
| let pkgs = bytecount::count(&pip.stdout, b'\n'); | ||
| let pkgs = pkgs as u32 - 2; |
There was a problem hiding this comment.
I tried to do it without them and cargo threw errors at me about how it's unable to do binary operations on strings. So I made them u32 and it worked.
There was a problem hiding this comment.
The previous value is an usize as returned by bytecount::count, so it should work.
There was a problem hiding this comment.
That's really weird. I swear I tried that before and it didn't work. But it's working now, so I'll edit and commit again.
lnicola
approved these changes
May 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.