Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default precision to 1/1000th of viewbox diagonal #19

Merged
merged 1 commit into from
May 13, 2021

Conversation

anthrotype
Copy link
Collaborator

this improves the warping of very long segments that span across the wave such as the flags' rectangles.
It doesn't increase the file size overall, since our initial parametrization is good enough that we very rarely end up exceeding the precision threshold

E.g. see this detail from the serbian flag, notice that the crown sits exactly at the limit between the red and blue horizontal stripes:

Screenshot 2021-05-13 at 16 46 37

After warping with the old default precision (1/200th of diagonal), the position of the emblem looks slightly off (notice the blue strip)

Screenshot 2021-05-13 at 16 38 55

With --precision=1000 it looks better and the emblem is perfectly aligned:

Screenshot 2021-05-13 at 16 46 09

this improves the warping of very long segments that span across the wave such as the flags' rectangles.
It doesn't increase the file size overall, since our initial parametrization is good enough that we very rarely end up exceeding the precision threshold
@anthrotype anthrotype merged commit b4679c1 into main May 13, 2021
anthrotype added a commit to googlefonts/noto-emoji that referenced this pull request May 13, 2021
sido378 pushed a commit to sido378/noto-emoji that referenced this pull request Jul 7, 2022
sido378 pushed a commit to sido378/noto-emoji that referenced this pull request Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant