Add border to SVG flags #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthrotype
force-pushed
the
add-border
branch
from
c42b9fb
to
7e7fbe2
Compare
anthrotype
added a commit
to googlefonts/noto-emoji
that referenced
this pull request
Jan 19, 2022
anthrotype
added a commit
to googlefonts/noto-emoji
that referenced
this pull request
Jan 19, 2022
Partly fixes #20 It turns out we don't actually need MULTIPLY compositing mode to stick a border around flags, normal alpha blending achieves the same visual effect (I suspect because the border is gray?). So we can add the border directly to the waved SVG flags (the soft-light we'll have to add it directly to the built COLRv1 table as post-processing step for SVG can't do soft-light -- or rather one could use CSS mix-blend-mode but it won't work for OT-SVG anyway so it's a dead end).
anthrotype
force-pushed
the
add-border
branch
from
7e7fbe2
to
1a0ea22
Compare
|
I rebased off |
|
LGTM |
sido378
pushed a commit
to sido378/noto-emoji
that referenced
this pull request
Jul 7, 2022
sido378
pushed a commit
to sido378/noto-emoji
that referenced
this pull request
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly fixes #20
It turns out we don't actually need MULTIPLY compositing mode to stick a border around flags, normal alpha blending achieves the same visual effect (I suspect because the border is gray?). So we can add the border directly to the waved SVG flags (the soft-light we'll have to add it directly to the built COLRv1 table as post-processing step for SVG can't do soft-light -- or rather one could use CSS mix-blend-mode but it won't work for OT-SVG anyway so it's a dead end).
Note this PR branch si based off #22, so to avoid conflicts it's better to merge the latter first.