Python 2 support #4
Conversation
* Use PYTHON3 constant (from sys.version_info) to special-case some behavior, with the goal of supporting Python 2.x * Several cases of list.copy() instead do list[:] when using Python 2.x * Renamed DataFrame's .print() -> .show() to avoid clash with "print" keyword. * Removed type hints
* Replace print() with show() * Tests shouldn't expect TypeError in many cases with Python 2, so code that would raise it under Python 3 isn't executed if running 2.x
|
Question, why does Python2.7 not raise a TypeError in the tests that have a mixed types for the index and attempt to get sorted? I see you had to remove those tests for Python2.7 and I am curious why. Thanks. I think I answered my own question here: https://docs.python.org/3.0/whatsnew/3.0.html#ordering-comparisons Do you think it is OK for pyhton2 and 3 to have different results? Or should the code somehow force an error on Python2 as well? |
|
Yeah, Python 2 is basically ¯\(ツ)/¯ when it comes to types, which is a blessing and a curse. Constantly checking the types of all of the items in the lists every time they're modified probably doesn't make a lot of sense, and most people who use Python 2 are aware of its quirks, so I wouldn't worry about it. |
Addresses #3, support for Python < 3.0