Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No pack() and unpack() methods for InterfaceStatistics and NameResolution #1

Closed
rpp0 opened this issue Aug 3, 2014 · 2 comments
Closed

Comments

@rpp0
Copy link
Contributor

rpp0 commented Aug 3, 2014

When iterating over pcapng blocks using PcapngReader, the reader will fail when an InterfaceStatistics or NameResolution block is encountered:

  File "/foo/pcapng/reader.py", line 216, in _parse_block
    return NameResolution.unpack(blk.contents, self._endianness)
AttributeError: type object 'NameResolution' has no attribute 'unpack'
@rshk
Copy link
Owner

rshk commented Aug 4, 2014

(See #2)

BTW, if you have some relevant examples of pcapng files with those blocks, it would be handy if you could put them somewhere so I can integrate them in the unit tests (was thinking about using a separate repo for example pcapng files.. the goal is finding ones that would break the library, and store them along with the name/version of the program which generated them).

@rshk
Copy link
Owner

rshk commented Dec 28, 2014

This is fixed with new refactoring (in progress). Pending close as soon as refactor branch is merged

@rshk rshk closed this as completed Dec 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants