Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defined packer and unpacker for NameResolution and InterfaceStats blocks #2

Merged
merged 1 commit into from
Aug 16, 2014

Conversation

rpp0
Copy link
Contributor

@rpp0 rpp0 commented Aug 3, 2014

I created some stubs for the NameResolution and InterfaceStats blocks to solve issue #1. Now the reader will continue parsing instead of terminating.

@rshk
Copy link
Owner

rshk commented Aug 4, 2014

(Also replying to #1)

..yeah, I didn't have much time to work on this project so I kinda suspended the development after a while, but it's great to see there's some interest around it; if so, I'm going to dedicate more time to it.

Thanks for the PR, I'm going to check it out soon and see what's stil missing to, at least, have a complete parser of the pcapng format..

@rpp0
Copy link
Contributor Author

rpp0 commented Aug 4, 2014

No problem! If you'd like, I can help you with the development of the library.

rshk added a commit that referenced this pull request Aug 16, 2014
Defined packer and unpacker for NameResolution and InterfaceStats blocks
@rshk rshk merged commit 3bd9b14 into rshk:master Aug 16, 2014
@rpp0 rpp0 deleted the nameresolution branch August 17, 2014 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants