Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate supports_statement_cache? #1321

Merged
merged 1 commit into from May 2, 2017

Conversation

koic
Copy link
Collaborator

@koic koic commented May 2, 2017

Follow up to rails/rails#28938.

@koic
Copy link
Collaborator Author

koic commented May 2, 2017

@yahonda After passing Travis CI build, should I open a PR that backporting this commit to nextval branch?

@koic
Copy link
Collaborator Author

koic commented May 2, 2017

Or is backporting unnecessary? There is a solution such as rebase master on nextval branch.

(About the function/branch of the future, the phrase "backporting" was strange.)

@koic koic merged commit 46a99fb into rsim:master May 2, 2017
@koic koic deleted the deprecate_supports_statement_cache branch May 2, 2017 06:38
@yahonda
Copy link
Collaborator

yahonda commented May 2, 2017

Thanks for your work and good question.

The short answer is no. Since nextval is a kind of topic branch (feature branch) which will be merged to master at some future, unlike other release18 branches.

In the meantime, I'll merge master branches into nextval branch periodically.

@yahonda
Copy link
Collaborator

yahonda commented May 2, 2017

I have merged master branch into nextval. c29bf31 . Going foward merge operation for nextval branch will be done without issues/pull requests.

@koic
Copy link
Collaborator Author

koic commented May 2, 2017

Thanks for your reply. I understood the policy of development on nextval branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants