remove_prefix_and_suffix handles dollar sign by Regexp#escape
#1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yahonda
force-pushed
the
regexp_remove_prefix_and_suffix
branch
from
29980bc
to
ef9aa9e
Compare
yahonda
force-pushed
the
regexp_remove_prefix_and_suffix
branch
from
ef9aa9e
to
7d2fa5a
Compare
|
This method will be removed once rails/rails#30048 is merged to Rails master. Regardless it is merged to Rails or not, Oracle enhanced adapter still needs to support the dollar sign for table_name_prefix and table_name_suffix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented at Oracle enhanced locally first for rails/rails#30044 Thanks @kamipo