Do not create sequences for primary keys #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`GENERATED BY DEFAULT AS IDENTITY` - `default_sequence_name` returns sequence name created by `GENERATED BY DEFAULT AS IDENTITY` - Remove `create_sequence_and_trigger` method - `reset_pk_sequence!` method changes the sequence value created by `GENERATED BY DEFAULT AS IDENTITY`. - Skip specs which do not pass right now Since this commit, there are some ActiveRecord unit tests start getting fail. It will be addressed later, in some mid term.
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Feb 14, 2018
`prefetch_primary_key?` returns `false` and `next_sequence_value` does nothing to see how identity data type works. It is similar with rsim#1483, but many sequence related code left since this is still a POC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not create sequences for primary keys. Sequences are generated by
GENERATED BY DEFAULT AS IDENTITYdefault_sequence_namereturns sequence name created byGENERATED BY DEFAULT AS IDENTITYcreate_sequence_and_triggermethodreset_pk_sequence!method changes the sequence value created byGENERATED BY DEFAULT AS IDENTITY.Since this commit, there are some ActiveRecord unit tests start getting
fail. It will be addressed later, in some mid term.