Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not set nil value to java.util.Properties #1763

Merged
merged 1 commit into from Aug 23, 2018
Merged

Do not set nil value to java.util.Properties #1763

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/active_record/connection_adapters/oracle_enhanced/jdbc_connection.rb
View file
Open in desktop
Expand Up @@ -125,6 +125,8 @@ def new_connection(config)
time_zone = config[:time_zone] || ENV["TZ"] || java.util.TimeZone.default.getID

properties = java.util.Properties.new
raise "username not set" unless username
raise "password not set" unless password
properties.put("user", username)
properties.put("password", password)
properties.put("defaultRowPrefetch", "#{prefetch_rows}") if prefetch_rows
Expand Down