Import visit_Arel_Nodes_{In,NotIn} from Rails code base
#2008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`connection.in_clause_length` and related code will be removed from Rails code base, so should be owned in the repo itself.
|
Thanks! |
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Dec 15, 2020
to use `visit_Arel_Nodes_HomogeneousIn` `visit_Arel_Nodes_HomogeneousIn` has been implemented in Rails 6.1 via rails/rails@72fd0bae594 and implemented for Oracle enhanced adapter via rsim#2013 . Refer rsim#2008 Fix rsim#2072
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connection.in_clause_lengthand related code will be removed fromRails code base, so should be owned in the repo itself.
Ref rails/rails#39057.