Refactor select() to use two parameters #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If I remember correctly I created this "hack for returning clause" because in AR tests "executed" method was aliased and it was counted how many time "execute" was called. If I will not call "execute" from insert_sql then I will get some failing tests - need to check that (see execute_with_query_record method in test/cases/helper.rb). Don't remember if there was any other reason :) |
|
I merged in your commits and added one small bugfix. Now all AR master branch tests are passing - don't know why I did this hack with instance variable :) If you need any help with adding statement cache to oracle adapter then let me know. |
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Nov 3, 2017
`JDBCConnection#exec_with_returning` Both of them have not called since rsim@5b1198b Refer rsim#33
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Nov 4, 2017
`JDBCConnection#exec_with_returning` Both of them have not called since rsim@5b1198b Refer rsim#33
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm refactoring ActiveRecord to add prepared statement caching. I need the adapters to use the same interface as the abstract adapter. These commits make the select method line up with the abstract adapter.
Once these are integrated, I will add the statement cache to the oracle adapter and send you a pull request.