Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow Oracle enhanced adapter rubocop configurations #144

Merged
merged 2 commits into from
Jan 13, 2018

Conversation

yahonda
Copy link
Collaborator

@yahonda yahonda commented Jan 13, 2018

Disabled Lint/EndAlignment and Style/FrozenStringLiteralComment

since these two offences need some more
investigations, cannot be fixed automatically.

  • Lint/EndAlignment would cause these two offenses.
$ rubocop lib/plsql/procedure_call.rb
Inspecting 1 file
W

Offenses:

lib/plsql/procedure_call.rb:331:9: W: Lint/EndAlignment: end at 331, 8 is not aligned with if at 320, 24.
        end
        ^^^
lib/plsql/procedure_call.rb:435:9: W: Lint/EndAlignment: end at 435, 8 is not aligned with if at 431, 23.
        end
        ^^^

1 file inspected, 2 offenses detected
$
  • Style/FrozenStringLiteralComment would cause FrozenError: in Ruby 2.5
   FrozenError:
       can't modify frozen String

Disabled `Lint/EndAlignment` and `Style/FrozenStringLiteralComment`

since these two offences need some more
investigations, cannot be fixed automatically.

* `Lint/EndAlignment` would cause these two offenses.

```ruby
$ rubocop lib/plsql/procedure_call.rb
Inspecting 1 file
W

Offenses:

lib/plsql/procedure_call.rb:331:9: W: Lint/EndAlignment: end at 331, 8 is not aligned with if at 320, 24.
        end
        ^^^
lib/plsql/procedure_call.rb:435:9: W: Lint/EndAlignment: end at 435, 8 is not aligned with if at 431, 23.
        end
        ^^^

1 file inspected, 2 offenses detected
$
```

* `Style/FrozenStringLiteralComment` would cause `FrozenError:` in Ruby 2.5

```
   FrozenError:
       can't modify frozen String
```
@yahonda yahonda merged commit 9628895 into rsim:master Jan 13, 2018
@yahonda yahonda deleted the add_some_more_cops branch January 13, 2018 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant