-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSKIP-186 - Active Federation creation block height #186
Conversation
23316cd
to
82a78e5
Compare
IPs/RSKIP186.md
Outdated
- activeFederationCreationBlockHeight. (long) | ||
- Defaults to the existing Federation activation height | ||
- nextFederationCreationBlockHeight. (long) | ||
- Defaults to the existing Federation activation height |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The names sound a bit confusing to me, I had to read a couple of times what the difference between each is.
Maybe:
federationCreationBlockHeight
federationActivationBlockHeight
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- activeFederationCreationBlockHeight: stores the active Federation creation height. This value is the one the user would get
- nextFederationCreationBlockHeight: this is a temporary value created when a new Federation is committed. This committed Federation won't be activated until the network's configuration delay is achieved.
I'll try better explaining this in the RSKIP.
Thanks!
a39c996
to
d8ec756
Compare
This doesn't seem to solve the issue that is addressing at the description.
An user requesting the current federation can't validate with this event that the address provided it is actually the current federation. The reasonable thing would be to have a storage key with the federation address and present a storage proof of it or something similar. |
You are correct @donequis, this is not enough to provide that functionality. But it's the required consensus change to be able to later create said functionality in the node itself (via an json-rpc method most likely) |
I think that this is not enough to create such functionality (at least not cleanly). With these changes a node will be able to find a block with the event and present a proof for such an event. The problem is that the user receiving the proof can't verify that the provided address is the actual federation address (i.e. there was no such an event after the given one). The user will be able to check that the address was at least active once in the past, which is not an enough guarantee. The only solution is to provide a proof of the height/tx execution and only then provide the event to the user. But it would be easier to save the federation address and send it directly to the user with a proof of storage |
IMO this RSKIP tries to address two independent problems and there are alternative solutions for both:
Solution 1 is more generic than this proposal and can be used in the future as part of the ERP recovery and could be supported by PowPeg hardware device if necessary, it can also be used in migrations (simplifying them?) Solution 2 allows a client without a full node to verify a merkle proof of a transaction receipt including an event with the multisig address and determine if it is the current one or not. The client needs to know the current blockchain height (as always) and the frequency of updates and reject proofs that are too old. |
Co-authored-by: Marcos Irisarri <53787863+marcos-iov@users.noreply.github.com>
f911ee4
to
2feb48f
Compare
No description provided.