RSKIP197 - Fix Precompile Calls Not Conforming With CALL Semantics

[fedejinich]

Introducing a new mechanism to handle errors on failed precompiled calls

[fedejinich]

I've just reopened this RSKIP with the specification @SergioDemianLerner @nagarev , any comments?

[SergioDemianLerner]

As far as I understand this change, the RSKIPS should have a single line and nothing more:

"Add REVERT capability to pre-compiled contracts"

That's all that is needed to understand the change. There is no need for examples.

[SergioDemianLerner]

I'm still trying to understand why this is a consensus change. The only reason I found is that this change might bring some unintended side-effects, so we synchronize the activation of this change with the Iris upgrade.

[fedejinich]

I'm still trying to understand why this is a consensus change. The only reason I found is that this change might bring some unintended side-effects, so we synchronize the activation of this change with the Iris upgrade.

Thats right, we are trying to synchronize some unexpected behavior from rskj that might affect a transaction final state. Do you think there's no need to include it as RSKIP?

Maybe we can do some sync-tests to validate a safe upgrade

[fedejinich]

here is a much simplified version of this RSKIP, a oneliner