Refactor flyover parsers #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcos-iov
reviewed
Sep 27, 2023
|
|
||
| import java.util.List; | ||
|
|
||
| public class FastBridgeParser extends StandardRedeemScriptParser { |
There was a problem hiding this comment.
Let's call it FlyoverRedeemScriptParser to be consistent with rskj
|
|
||
| List<ScriptChunk> subChunks = redeemScriptChunks.subList(2, redeemScriptChunks.size()); | ||
| if (isFastBridgeMultiSig(redeemScriptChunks)) { | ||
| this.multiSigType = MultiSigType.FAST_BRIDGE_MULTISIG; |
There was a problem hiding this comment.
The way I see it we should a single MultiSigType for flyover. Do you think that's feasible? So we avoid adding new types for flyover everytime there is a new script type
There was a problem hiding this comment.
I absolutely agree. Mainly because you can simply remove the flyover values and check for the type as usual.
But should we keep the types for consensus? Are they used besides from testing?
| @@ -123,6 +123,10 @@ public Script extractStandardRedeemScript() { | |||
| return new Script(redeemScriptChunks); | |||
| } | |||
|
|
|||
| public static Script extractStandardRedeemScript(List<ScriptChunk> redeemScriptChunks) { | |||
There was a problem hiding this comment.
We don't really need this here. The redeem script itself is standard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.