Avoid possible NPE when searching for event in past blocks #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pipeline:run |
|
Remember to rebase with master. |
src/main/java/co/rsk/federate/signing/hsm/message/ReleaseCreationInformationGetter.java
Show resolved
Hide resolved
src/main/java/co/rsk/federate/signing/hsm/message/ReleaseCreationInformationGetter.java
Outdated
Show resolved
Hide resolved
src/main/java/co/rsk/federate/signing/hsm/message/ReleaseCreationInformationGetter.java
Outdated
Show resolved
Hide resolved
src/main/java/co/rsk/federate/signing/hsm/message/ReleaseCreationInformationGetter.java
Show resolved
Hide resolved
src/test/java/co/rsk/federate/signing/hsm/message/ReleaseCreationInformationGetterTest.java
Outdated
Show resolved
Hide resolved
src/test/java/co/rsk/federate/signing/hsm/message/ReleaseCreationInformationGetterTest.java
Outdated
Show resolved
Hide resolved
src/test/java/co/rsk/federate/signing/hsm/message/ReleaseCreationInformationGetterTest.java
Outdated
Show resolved
Hide resolved
src/test/java/co/rsk/federate/signing/hsm/message/ReleaseCreationInformationGetterTest.java
Outdated
Show resolved
Hide resolved
src/test/java/co/rsk/federate/signing/hsm/message/ReleaseCreationInformationGetterTest.java
Outdated
Show resolved
Hide resolved
src/test/java/co/rsk/federate/signing/hsm/message/ReleaseCreationInformationGetterTest.java
Show resolved
Hide resolved
|
pipeline:run |
marcos-iov
previously approved these changes
Apr 25, 2024
|
pipeline:run |
marcos-iov
force-pushed
the
fix/code_smell
branch
from
831a755
to
0f26e5c
Compare
marcos-iov
force-pushed
the
fix/code_smell
branch
from
0f26e5c
to
6a18a50
Compare
|
marcos-iov
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The method
receiptStore.getInMainChain(transaction.getHash().getBytes(), blockStore)returns anOptional. The code is not currently checking if the value is present in the returnedOptional.There is no reason really for the transaction to not be in the storage, if it’s part of the block then the transaction should exist. But avoiding this check is what’s causing a code smell.
Note: Added minor refactor.
Test Plan
Added unit test, and verified with
./gradlew test