added change network method #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chescalante
commented
Sep 30, 2021
chescalante
commented
chescalante
force-pushed
the
feature/US-210-change-network
branch
from
275fe17
to
0deb443
Compare
ilanolkies
suggested changes
Oct 4, 2021
There was a problem hiding this comment.
I would expand a little bit further on this feature:
- Metamask -> allows to switch via RPC
- Nifty/Liquiality -> displays message "Please change the network in your wallet"
- Wallet Connect -> depends on the device. Displays message "Please configure the network in your device"
- Torus and hardware wallets -> "Do you want to disconnect your device and connect it to another network?" and button does disconnect and go to step choose network
jessgusclark
approved these changes
Oct 6, 2021
This was referenced Oct 6, 2021
ilanolkies
added a commit
that referenced
this pull request
Oct 6, 2021
* added modal to show wallet information * mock TextEncoder * review changes * fix tests * fix cypress tests * added REACME docs about showModalInfo * changed showModalInfo to showWalletInfo and refactor readme doc * added change network method * added showChangeNetwork doc * minor change Co-authored-by: Christian Escalante <chescalante@gmail.com> Co-authored-by: Ilan <36084092+ilanolkies@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.