PP-183: create a tool to generate L2 private keys

[kenny08gt]

What

Create a command to generate a wallet on L2, with giving credentials (address and private key) or generate a new random one.

Why

In deployment of the project that was needed

Ref

https://rsklabs.atlassian.net/browse/PP-183

[kenny08gt]

Added a rust file to generate the wallet, the output is the print of the key
ETH Address: 0xe0072a000f359e97164282581aae281358571614 Private key: 0x4361ba8675c0560561bc32f2978fdfdf3863a3a72c9bb64d3d02a2e992bafb21

Navigate to ri-aggregation/core/lib/wallet_creator, build with cargo build and then run it with cargo run rif_aggreation_wallet_creator to create a random one.

run cargo run rif_aggreation_wallet_creator <eth_address> <private_key> to add a L1 to L2.

[antomor]

@kenny08gt Thank you for this.
Apart from the comments I left, I think we should also include the new command in the related readme if any, if not we should create a new one to include the instructions on how to run it.

[jurajpiar]

LG

[antomor]

@kenny08gt Thank you for these changes. I've just left some minor comments.

[antomor]

Apart from the comments I left,

1. In the README.md file I'd specify that we need to an instance of the zkserver running locally. QQ: where the server address is retrieved exactly? Could we use the command pointing to a remote server?
2. I'd print the private key of the wallet just generated, otherwise the tools isn't useful 😅

[kenny08gt]

@antomor thanks for the review.

In the README.md file I'd specify that we need to an instance of the zkserver running locally.

Added more instructions.

where the server address is retrieved exactly? Could we use the command pointing to a remote server?

Added support to multiple networks. Here is setup the server to point and in line 51 the provider is initialized.

I'd print the private key of the wallet just generated, otherwise the tools isn't useful

Is already printing the addresses.

Also added three unit tests

[antomor]

@kenny08gt Thank you for the changes.

I'd print the private key of the wallet just generated, otherwise the tools isn't useful

Is already printing the addresses.

Yes, this is true, but unless I'm missing something, we are currently printing the address/private key received, while we should print the L2 private key we are creating.

The test part is really appreciated, thank you. Not sure about what's the standard in rust, but I think it would be better to have them in a separate file, possibly in the test folder.

Furthermore, I've suggested a clarification for the readme file.

[kenny08gt]

@antomor thanks for the explanation. Now printing the L2 private key and also separate the tests to separate file.