Refactor did auth #51
Conversation
Now auth manager just understands get auth token message
Codecov Report
@@ Coverage Diff @@
## develop #51 +/- ##
===========================================
- Coverage 85.19% 84.35% -0.85%
===========================================
Files 16 18 +2
Lines 385 377 -8
Branches 54 49 -5
===========================================
- Hits 328 318 -10
- Misses 57 59 +2
Continue to review full report at Codecov.
|
|
|
||
| // api | ||
| const getAccessToken = async () => { | ||
| const accessToken = await storage.get(ACCESS_TOKEN_KEY) |
There was a problem hiding this comment.
| const accessToken = await storage.get(ACCESS_TOKEN_KEY) | |
| const accessToken = await getStoredAccessToken() |
There was a problem hiding this comment.
Fixed in following pr
| export type DIDAuthConfig = { | ||
| did?: string | ||
| serviceUrl: string | ||
| serviceDid?: string // TODO: unused, if we verify challenge request we should use it to assert signer, otherwise remove it |
There was a problem hiding this comment.
You're right, it was used before we changed the way we sign in the login process. Anyway, I think we should verify that the signer is the one we expect to be because is supposed that the DV client must trust in the DV service.
There was a problem hiding this comment.
Do we open an issue for this?
There was a problem hiding this comment.
Already opened, let's remove it for now #56
This PR adds only one breaking change:
rpcPersonalSignname forpersonalSign. It is not necessary for personal sign to be via RPC.Other changes:
getAuthTokenandstoredTokensmessages