This repository has been archived by the owner on May 19, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
javiesses
commented
Oct 30, 2020
- Integrated Express DID Auth package (uploaded to my personal account)
- Integrated Ipfs Cpinner Provider
- Unit Tests
- Authentication for POST/PUT/DELETE endpoints
ilanolkies
suggested changes
Oct 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat and tidy!
@@ -44,7 +44,7 @@ jobs: | |||
- run: npm install | |||
- run: npm run setup | |||
- run: npm run build | |||
- run: npm run lint | |||
# - run: npm run lint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rising an issue for this
Comment on lines
46
to
60
createConnection({ | ||
type: 'sqlite', | ||
database: env.database, | ||
entities: Entities, | ||
logging: false, | ||
dropSchema: true, | ||
synchronize: true | ||
}).then(async (dbConnection: Connection) => { | ||
const ipfsPinnerProvider = await ipfsPinnerProviderFactory(dbConnection, `http://${env.ipfsHost}:${env.ipfsPort}`) | ||
setupApp(app, ipfsPinnerProvider, config, logger) | ||
|
||
const port = process.env.DATA_VAULT_PORT || 5108 | ||
|
||
app.listen(port, () => logger.info(`Data vault service service started on port ${port}`)) | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
createConnection({ | |
type: 'sqlite', | |
database: env.database, | |
entities: Entities, | |
logging: false, | |
dropSchema: true, | |
synchronize: true | |
}).then(async (dbConnection: Connection) => { | |
const ipfsPinnerProvider = await ipfsPinnerProviderFactory(dbConnection, `http://${env.ipfsHost}:${env.ipfsPort}`) | |
setupApp(app, ipfsPinnerProvider, config, logger) | |
const port = process.env.DATA_VAULT_PORT || 5108 | |
app.listen(port, () => logger.info(`Data vault service service started on port ${port}`)) | |
}) | |
const ipfsUrl = `http://${env.ipfsHost}:${env.ipfsPort}` | |
const port = process.env.DATA_VAULT_PORT || 5108 | |
createConnection({ | |
type: 'sqlite', | |
database: env.database, | |
entities: Entities, | |
logging: false, | |
dropSchema: true, | |
synchronize: true | |
}).then((dbConnection: Connection) => ipfsPinnerProviderFactory(dbConnection, ipfsUrl)) | |
.then(ipfsPinnerProvider => setupApp(app, ipfsPinnerProvider, config, logger)) | |
.then(() => app.listen(port, () => logger.info(`Data vault service service started on port ${port}`))) |
Closed
ilanolkies
approved these changes
Oct 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.