REL-004: expiration mechanism #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ironFe93
requested review from
a team and
ulasanil
and removed request for
ulasanil
antomor
force-pushed
the
PP-583/REL-004
branch
from
008e08e
to
39e3624
Compare
fix: missing test parameter, missing compilation feat: add encode params fix: tests fix: add expiration parameter to tests fix: add missing parameters to TypedRequestData.ts fix: attempt to fix tests fix: add missing encodes fix: number to string fix: missing parameter on test fix: remove parameter from fctory contract fix: request param string to number Revert "fix: request param string to number" This reverts commit db690fe. feat: implement check on wallet deployment chore: update package version
antomor
force-pushed
the
PP-583/REL-004
branch
from
39e3624
to
232c630
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
https://rsklabs.atlassian.net/browse/PP-583
Refs
Unit tests inluded in this PR: #104