Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PP-669: Migrate the NativeHolderSmartWallet contract tests to ethers #123

Merged
merged 8 commits into from
Feb 22, 2023
Merged

PP-669: Migrate the NativeHolderSmartWallet contract tests to ethers #123

merged 8 commits into from
Feb 22, 2023

Conversation

antomor
Copy link
Collaborator

@antomor antomor commented Feb 17, 2023 •
edited

What

  • Migrate the NativeHolderSmartWallet tests to ethers
  • Support the NativeHolderSmartWallet in the allowTokens and removeTokens script
  • Rename directExecuteWithValue to directExecute

Why

  • Tests were written with truffle/web3

@antomor antomor self-assigned this Feb 17, 2023
@antomor antomor changed the title feat(WIP): allow and remove tokens from nativeHolderSmartWallet PP-669: Migrate the NativeHolderSmartWallet contract tests to ethers Feb 20, 2023
@antomor antomor marked this pull request as ready for review February 20, 2023 15:29
@antomor antomor requested a review from a team February 20, 2023 15:29
@antomor antomor added the enhancement New feature or request label Feb 20, 2023
AndresQuijano
AndresQuijano approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@AndresQuijano AndresQuijano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment.

ironFe93
ironFe93 approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@ironFe93 ironFe93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left a few comments which are just minor details.

test/smartwallet/nativeHolderSmartWallet.test.ts Outdated Show resolved Hide resolved
test/smartwallet/nativeHolderSmartWallet.test.ts Outdated Show resolved Hide resolved
test/smartwallet/nativeHolderSmartWallet.test.ts Outdated Show resolved Hide resolved
test/smartwallet/nativeHolderSmartWallet.test.ts Outdated Show resolved Hide resolved
@antomor
Copy link
Collaborator Author

antomor commented Feb 22, 2023

@AndresQuijano @ironFe93 thank you for reviewing it, I've applied your suggestions (plus additional changes similar to what you requested). Could you please review it again?

ironFe93
ironFe93 approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@ironFe93 ironFe93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @antomor , LGTM

@antomor antomor merged commit 3d14eb0 into main Feb 22, 2023
@antomor antomor deleted the PP-668/migrate-NativeHolderSmartWallet branch February 22, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ironFe93 ironFe93 ironFe93 approved these changes

@AndresQuijano AndresQuijano Awaiting requested review from AndresQuijano

Assignees

@antomor antomor

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@antomor @ironFe93 @AndresQuijano