New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PP-671/custom-smart-wallet-factory-migration #130

Merged

franciscotobar merged 3 commits into main from PP-671/custom-smart-wallet-factory-unit-tests

Mar 28, 2023

Contributor

franciscotobar commented Mar 22, 2023 •

edited

What

Migrate CustomSmartWalletFactory unit testing

Why

Part of the web3 to ethers migration

Refs

PP-671

franciscotobar force-pushed the PP-671/custom-smart-wallet-factory-unit-tests branch 2 times, most recently from d5e5b9a to 3d4a39a Compare

March 24, 2023 03:29

franciscotobar changed the title ~~test(CustomSmartWalletFactory): migration~~ PP-671/custom-smart-wallet-factory-migration

franciscotobar added 2 commits

March 24, 2023 08:04


          test(CustomSmartWalletFactory): migration

9c6a77b


          test: refactor common utils

9de815a

franciscotobar force-pushed the PP-671/custom-smart-wallet-factory-unit-tests branch from 3d4a39a to 9de815a Compare

March 24, 2023 14:58

franciscotobar marked this pull request as ready for review

March 24, 2023 15:02

franciscotobar requested a review from a team

March 24, 2023 15:03

AndresQuijano reviewed

View reviewed changes

test/factory/customSmartWalletFactory.test.ts Outdated Show resolved Hide resolved

AndresQuijano reviewed

View reviewed changes

test/factory/customSmartWalletFactory.test.ts Outdated Show resolved Hide resolved

AndresQuijano reviewed

View reviewed changes

test/factory/customSmartWalletFactory.test.ts Outdated Show resolved Hide resolved

AndresQuijano reviewed

View reviewed changes

test/factory/customSmartWalletFactory.test.ts Show resolved Hide resolved

AndresQuijano reviewed

View reviewed changes

Contributor

AndresQuijano left a comment

Minor comments.

franciscotobar requested a review from AndresQuijano

March 28, 2023 01:31


          refactor: pr comments

c353303

franciscotobar force-pushed the PP-671/custom-smart-wallet-factory-unit-tests branch from 3898456 to c353303 Compare

March 28, 2023 03:12

AndresQuijano approved these changes

View reviewed changes

franciscotobar merged commit 188d7ee into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment