Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PP-840: get allowed tokens for given verifiers only #136

Merged
merged 12 commits into from
Oct 19, 2023
Merged

PP-840: get allowed tokens for given verifiers only #136

merged 12 commits into from
Oct 19, 2023

Conversation

antomor
Copy link
Collaborator

@antomor antomor commented Sep 19, 2023

What

  • change the allowed-tokens to receive the verifiers to check
  • change the allow-tokens to receive the verifiers to modify

Why

  • to make the script more flexible and avoid asking for unnecessary data

@antomor antomor self-assigned this Sep 19, 2023
@antomor antomor marked this pull request as ready for review September 19, 2023 15:37
@antomor antomor requested a review from a team September 19, 2023 15:37
franciscotobar
franciscotobar reviewed Sep 20, 2023
View reviewed changes
hardhat.config.ts Outdated Show resolved Hide resolved
franciscotobar
franciscotobar approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@franciscotobar franciscotobar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antomor antomor merged commit 020db49 into main Oct 19, 2023
1 check passed
@antomor antomor deleted the PP-840/change-get-allowed-tokens branch October 19, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franciscotobar franciscotobar franciscotobar approved these changes

Assignees

@antomor antomor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@antomor @franciscotobar