Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/PP-45 #43

Merged
merged 20 commits into from
Jul 29, 2022
Merged

feature/PP-45 #43

merged 20 commits into from
Jul 29, 2022

Conversation

franciscotobar
Copy link
Contributor

@franciscotobar franciscotobar commented Jul 13, 2022 •
edited

What

  • Solve circular dependency found when including unit tests in rif-relay-contracts
  • Add unit testing for each dependency for the Rif Relay Project

Why

  • Circular dependencies must be avoided in most of the situations
  • Each project needs to have their own way of testing

Refs

@franciscotobar franciscotobar requested review from antomor and a team July 13, 2022 21:33
antomor
antomor requested changes Jul 18, 2022
View reviewed changes
Copy link
Collaborator

@antomor antomor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I don't have any issue when I try to install and build the package, I've left some doubts.

test/Constants.ts Show resolved Hide resolved
index.ts Show resolved Hide resolved
package.json Show resolved Hide resolved
This was referenced Jul 21, 2022
Merged
Merged
@franciscotobar franciscotobar requested a review from a team July 21, 2022 19:46
This was referenced Jul 21, 2022
Merged
Merged
Merged
antomor
antomor approved these changes Jul 29, 2022
View reviewed changes
Copy link
Collaborator

@antomor antomor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antomor antomor merged commit 7b94a92 into master Jul 29, 2022
@antomor antomor deleted the feature/PP-45 branch July 29, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antomor antomor antomor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@franciscotobar @antomor