Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-504/remove-worker-configuration #44

Merged
merged 4 commits into from
Nov 17, 2022
Merged

Conversation

franciscotobar
Copy link

@franciscotobar franciscotobar commented Nov 14, 2022

What

  • Get the feesReceiver/Partners from the server/contracts

Why

  • To simplify the process when the revenue feature its being used

Refs

@franciscotobar franciscotobar force-pushed the PP-504/remove-worker-configuration branch from 73de28f to 61d40f2 Compare November 14, 2022 16:58
package.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@antomor antomor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@franciscotobar thank you for the changes. I've tried the dap with and without a collector contract and it works like a charm 🪄

src/components/PartnerBalances.tsx Show resolved Hide resolved
Copy link
Collaborator

@antomor antomor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antomor antomor merged commit 90e9882 into dev Nov 17, 2022
@antomor antomor deleted the PP-504/remove-worker-configuration branch November 17, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants