Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/live prices #14

Merged
merged 51 commits into from
Jan 4, 2022
Merged

Feature/live prices #14

merged 51 commits into from
Jan 4, 2022

Conversation

agustin-v
Copy link
Contributor

@agustin-v agustin-v commented Dec 21, 2021 •
edited by jessgusclark
Loading

Updated CoinMarketCap class to receive chainId in the constructor to pick the right dictionary.
Updated tests for CoinMarketCap
Updated validatePricesRequest function by adding chainId as new parameter.
Updated validatePricesRequest function by adding chainId as new parameter.
Updated RSKExplorer API to work with the chainId in order to validate the price requests

.env

COIN_MARKET_CAP_KEY=....
DEFAULT_CONVERT_FIAT=USD

Prices endopoint

http://localhost:3000/price?convert=USD&addresses=0x19f64674d8a5b4e652319f5e239efd3bc969a1fe

Address wallet for sockets

{
  "address": "0x3F6750bB87Bdffa7C04377e155cCA62aB9BBe8a0"
}

agustin-v and others added 30 commits December 8, 2021 13:47
@agustin-v
Adding CoinMarketCap types
d9468ba
@agustin-v
CoinMarketCap class to access the quotas(prices) of each token or coin
2fe5713
@agustin-v
Added type for query params for the prices endpoint
a8eaa96
@agustin-v
Changing return type
307ab2e
@agustin-v
Changing return type
0579d74
@agustin-v
Adding price endpoint
3127777
@agustin-v
Function to convert a new Date object into UTC epoch
25ec8e0
@agustin-v
Adding loki js to cache the amount of requests we have performed to t…
ef96c6a 
…he coinmarketcap api
@agustin-v
Implementing lokijs to cache the request count and data from coinmark…
79228b5 
…etcap
@agustin-v
Removing cache system and lokijs
739e7b8
@agustin-v
Adding types for metadata
e49e91e
@agustin-v
Removing error handling from the coinmarketcap lib
3b490ee
@agustin-v
Types for metadata response
78dcd26
@agustin-v
Adding sanitization functions for metadata and quote results
e93c731
@agustin-v
Running linter
e5b1485
@agustin-v
Endpoint for prices.
7682b84
@agustin-v
Reunning linter
6670340
@agustin-v
Merging develop into feature branch to remove conflicts
d0a1786
@agustin-v
Fixing types syntax
c1a5136
@ilanolkies
Move parsing logic to coinmarketcap.ts
b219ab9
@ilanolkies
Move files
c7e0de9
@ilanolkies
Refactor api
714f13f
@ilanolkies
Lint
600950a
@ilanolkies
Refactor json result
c487e6e
@ilanolkies
Add tests
fd133fb
@ilanolkies
Add error handling tests - move validatoins to api
696483c
Fixing merging issues
aa84621
Merging updated-live-balances
c84f755
Polling function for coinmarketcap prices
d5ceeb2
Implemented pushNewPrices socket based on wallet address
6a1c294
@agustin-v agustin-v changed the base branch from develop to feature/live-balances December 21, 2021 19:00
ilanolkies
ilanolkies suggested changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@ilanolkies ilanolkies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/subscriptions/pushNewPrices.ts Outdated Show resolved Hide resolved
@ilanolkies ilanolkies mentioned this pull request Dec 22, 2021
Closed
Agustin Villalobos added 14 commits December 27, 2021 17:35
Update list of supported tokens by coinmarketcap
00a154a
Filtering out unsupported tokens
31b362e
Commenting out the validatePricesRequest function which validates if …
7f6fe29 
…the token is supported or not, since we are doing that inside the coinmarketcap function
Commenting out the validatePricesRequest function which validates if …
94bb4c4 
…the token is supported or not, since we are doing that inside the coinmarketcap function
coinmarketcap api will fail if no ids passed therefore we added an if…
33a379e 
… if there are no addresses
adding an empty json as default value for prices, in case the wallet …
8f36bc7 
…doesnt have any token yet, the backend wont crash because of the coinmarket cap api no receiving tokens ids
fixing merging issues
04cb38e
Lint
8eec61b
Adding only supported tokens
1f11902
exporting isConvertSupported function
4d5b7a6
Lint
a62c9b2
Adding conditions to handle unsupported convert or addresses
67d4bba
Modifying tests to handle new responses
e98cd36
Adding chainId as parameter to the subscriptions
c1104ac
@agustin-v agustin-v marked this pull request as ready for review January 3, 2022 19:34
chescalante
chescalante approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@chescalante chescalante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chescalante chescalante merged commit dde2abe into feature/live-balances Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilanolkies ilanolkies ilanolkies requested changes

@chescalante chescalante chescalante approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@agustin-v @chescalante @ilanolkies