create master key & import master key #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chescalante
commented
Oct 22, 2021
•
chescalante
commented
chescalante
force-pushed
the
feature/US-289-create-wallet
branch
from
0174596
to
0d3f55c
Compare
ilanolkies
added
enhancement
ilanolkies
requested changes
Oct 25, 2021
There was a problem hiding this comment.
I merged from main and tests started failing. There was no big change... I guess something is wrong in the tests, it never ran locally.
Only one change requested: where to save the mnemonic. Great job! This change should also modify how tests are built. I didn't revert my changes.
Comment on lines
+19
to
+21
| useEffect(() => { | ||
| saveMnemonic(mnemonic) | ||
| }, [mnemonic]) |
There was a problem hiding this comment.
I would call this in Confirm and Import components
ilanolkies
reviewed
Oct 25, 2021
ilanolkies
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.